Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop close button[X] on Authorization prompt from closing manta-signer #166

Merged
merged 6 commits into from
Aug 24, 2022
Merged

Stop close button[X] on Authorization prompt from closing manta-signer #166

merged 6 commits into from
Aug 24, 2022

Conversation

Apokalip
Copy link
Contributor

@Apokalip Apokalip commented Aug 22, 2022 •
edited
Loading

Signed-off-by: Apokalip simeon@manta.network

Fixes: #93

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@vercel
Copy link

vercel bot commented Aug 22, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Aug 24, 2022 at 10:16PM (UTC)

@Apokalip Apokalip self-assigned this Aug 22, 2022
@Apokalip Apokalip linked an issue Aug 22, 2022 that may be closed by this pull request
Signer crashes when trying to cancel to_private or private_trasnfer #93
Closed
@Apokalip Apokalip added the DO-NOT-MERGE Labels a PR that should not be merged label Aug 22, 2022
@Apokalip
Fixing Auth window
e6d0c41 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip
Adding authorization abort
d38583e 
Signed-off-by: Apokalip <simeon@manta.network>
@Apokalip Apokalip added C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog A-tauri Area: Issues and PRs related to Tauri and removed DO-NOT-MERGE Labels a PR that should not be merged labels Aug 22, 2022
@Apokalip Apokalip changed the title Stop closing button on Authorization prompt from closing manta-signer Stop close button[X] on Authorization prompt from closing manta-signer Aug 22, 2022
@Apokalip
Update CHANGELOG.md
ff12cf3 
Signed-off-by: Simeon Zahariev <43317481+Apokalip@users.noreply.github.com>
Kevingislason
Kevingislason previously approved these changes Aug 24, 2022
View reviewed changes
@bhgomes
Merge branch 'main' into Apokalip/auth_prompt
16f3394 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes
add documentation
227ba9b 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@Kevingislason Kevingislason merged commit d0df86d into main Aug 24, 2022
@Kevingislason Kevingislason deleted the Apokalip/auth_prompt branch August 24, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhgomes bhgomes bhgomes approved these changes

@Kevingislason Kevingislason Kevingislason approved these changes

@codecarrier1 codecarrier1 Awaiting requested review from codecarrier1

Assignees

@Apokalip Apokalip

Labels
A-tauri Area: Issues and PRs related to Tauri C-bug Category: Issues documenting a bug L-fixed Changelog: add these changes to the `fixed` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signer crashes when trying to cancel to_private or private_trasnfer
3 participants
@Apokalip @bhgomes @Kevingislason