Signer Redesign #179
Closed
Signer Redesign #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kevingislason
previously approved these changes
Nov 12, 2022
bhgomes
suggested changes
Nov 15, 2022
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>
Co-authored-by: Brandon H. Gomes <bhgomes@pm.me> Signed-off-by: Alexander Parsh <53206800+AlexParshh@users.noreply.github.com>
bhgomes
approved these changes
Nov 22, 2022
Kevingislason
approved these changes
Nov 24, 2022
3 tasks
|
Made a copy of this PR in #215 due to merging issues with signing old commits. Closing this PR since the new one has already been merged. Release v1.0.0 PR has been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a new polished signer UI, including the ability to export a mnemonic phrase tied to an account, the ability to recover using an existing mnemonic phrase and switching away from a 24 word phrase to a 12 word phrase. It also includes new features such as account deletion and the ability to support transacting on multiple networks (Manta, Calamari & Dolphin).
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.