Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add multiple origin URLs for CORS #180

Merged
merged 3 commits into from
Oct 5, 2022
Merged

feat: add multiple origin URLs for CORS #180

merged 3 commits into from
Oct 5, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Oct 5, 2022 •
edited
Loading

Signed-off-by: Brandon H. Gomes bhgomes@pm.me

Adds https://app.manta.network to the CORS allowed origins setting and general support for multiple origins in the future.

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate changelog label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@bhgomes
feat: add multiple origin URLs for CORS
43ba8d1 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@vercel
Copy link

vercel bot commented Oct 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Oct 5, 2022 at 7:36PM (UTC)

@bhgomes
chore: add CHANGELOG entry
5d0c25c 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Oct 5, 2022
@bhgomes
fix: use correct string conversion
e4a8b39 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Kevingislason
Kevingislason approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested against production Dolphin front end, looks good

@Kevingislason Kevingislason merged commit eaa1851 into main Oct 5, 2022
@Kevingislason Kevingislason deleted the feat/update-cors branch October 5, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kevingislason Kevingislason Kevingislason approved these changes

@AlexParshh AlexParshh AlexParshh approved these changes

@Apokalip Apokalip Awaiting requested review from Apokalip

@Boyuan-Deng Boyuan-Deng Awaiting requested review from Boyuan-Deng

Assignees
No one assigned
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @Kevingislason @AlexParshh