Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow #40

Merged
2 commits merged into from
Jan 13, 2022
Merged

Add workflow #40

2 commits merged into from
Jan 13, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jan 3, 2022

This will need a REPO_ACCESS_TOKEN secret set up with write permissions, in order to create a tag.

@ghost ghost requested review from bhgomes and Kevingislason January 3, 2022 17:00
bhgomes
bhgomes suggested changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@bhgomes bhgomes left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The most important change is to fetch from the SDK instead of the manta-api releases.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/trigger.yml Outdated Show resolved Hide resolved
.github/workflows/trigger.yml Outdated Show resolved Hide resolved
Kevingislason
Kevingislason reviewed Jan 4, 2022
View reviewed changes
Copy link
Contributor

@Kevingislason Kevingislason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, this will improve our lives a lot.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/trigger.yml Outdated Show resolved Hide resolved
.github/workflows/trigger.yml Outdated Show resolved Hide resolved
@ghost ghost force-pushed the add-release-workflow branch from 5913b98 to b6e4f88 Compare January 13, 2022 20:49
@ghost ghost merged commit 072d236 into master Jan 13, 2022
@ghost ghost deleted the add-release-workflow branch January 13, 2022 21:10
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Jul 26, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhgomes @Kevingislason @kdense521