Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add js libs #52

Merged
merged 27 commits into from
Feb 9, 2022
Merged

Add js libs #52

merged 27 commits into from
Feb 9, 2022

Conversation

Kevingislason
Copy link
Contributor

@Kevingislason Kevingislason commented Feb 2, 2022

Description

see also https://github.com/Manta-Network/manta-js/pull/22

Move the end to end test pipeline plus relevant libraries from manta-js to this repo. Most files are simply moved from there unchanged, with a few exceptions:

-Tweaked the release pipeline to cache files based on matrix.os instead of runner.os. This was inconsistently causing one of the Ubuntu builds to fails. cc @tommyjk21
-Changed simulator code to avoid zero-value private transfers, which the runtime doesn't allow cc @bhgomes
-Moved simulator directory into e2e. It seems like the simulator "belongs to" the end to end test, and it's strange to have a rust package at the top level of the js folder. In any case, I think this is getting replaced soon. cc @bhgomes


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [n/a] Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • [n/a] Update the version numbers properly:
    • Cargo.toml
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json
    • ui/public/about.html
    • ui/package.json

@Kevingislason Kevingislason requested review from a user and bhgomes February 4, 2022 05:18
@Kevingislason Kevingislason marked this pull request as ready for review February 4, 2022 05:18
Copy link

@tjsharp1 tjsharp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Kevingislason Kevingislason merged commit 1c62b27 into master Feb 9, 2022
@Kevingislason Kevingislason deleted the add-js-libs branch February 9, 2022 20:25
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants