Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manta-RS Integration #57

Merged
merged 63 commits into from
May 19, 2022
Merged

Manta-RS Integration #57

merged 63 commits into from
May 19, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented Feb 14, 2022

Description

This PR transitions the signer core logic to the manta-rs codebase.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • Update the version numbers properly:
    • Cargo.toml
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json
    • ui/public/about.html
    • ui/package.json

@bhgomes bhgomes self-assigned this Feb 14, 2022
@bhgomes bhgomes marked this pull request as ready for review March 1, 2022 05:05
@bhgomes bhgomes requested review from Kevingislason, a user and stechu March 1, 2022 20:48
Cargo.toml Outdated Show resolved Hide resolved
Kevingislason
Kevingislason previously approved these changes May 19, 2022
ghost
ghost previously approved these changes May 19, 2022
@bhgomes bhgomes requested review from Kevingislason and a user May 19, 2022 19:46
@bhgomes bhgomes linked an issue May 19, 2022 that may be closed by this pull request
@bhgomes bhgomes merged commit 8f13224 into main May 19, 2022
@bhgomes bhgomes deleted the manta-rs-integration branch May 19, 2022 20:47
@bhgomes bhgomes added the L-changed Changelog: add these changes to the `changed` section of the changelog label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-changed Changelog: add these changes to the `changed` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducible Build for Supported Platforms
5 participants