Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move landing page from manta-signer-install #89

Merged
merged 17 commits into from
Jun 13, 2022

Conversation

bhgomes
Copy link
Contributor

@bhgomes bhgomes commented May 24, 2022

Description

It makes the most sense to keep the signer landing page close to the signer.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Test following procedure in docs/testing-workflow.md
  • Updated relevant documentation in the code.
  • Re-reviewed Files changed in the Github PR explorer.
  • Update the version numbers properly:
    • Cargo.toml
    • ui/package.json
    • ui/public/about.html
    • ui/src-tauri/Cargo.toml
    • ui/src-tauri/tauri.conf.json

@bhgomes bhgomes marked this pull request as draft May 24, 2022 04:23
@vercel
Copy link

vercel bot commented May 24, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
manta-signer ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 2:25PM (UTC)

@bhgomes
Copy link
Contributor Author

bhgomes commented Jun 2, 2022

@dansofter @tommyjk21 How do we get the Dolphin SVG to work? It seems to work on https://github.com/manta-network/manta-signer-install but I couldn't figure out how to get it to work here.

@bhgomes bhgomes marked this pull request as ready for review June 2, 2022 03:55
@bhgomes bhgomes requested a review from a user June 2, 2022 03:55
ghost
ghost previously approved these changes Jun 6, 2022
@Kevingislason Kevingislason added this to the v0.6.1 milestone Jun 9, 2022
Signed-off-by: tommyjk21 <92386732+tommyjk21@users.noreply.github.com>
Signed-off-by: tommyjk21 <92386732+tommyjk21@users.noreply.github.com>
Signed-off-by: tommyjk21 <92386732+tommyjk21@users.noreply.github.com>
ghost
ghost previously approved these changes Jun 13, 2022
Copy link
Contributor

@codecarrier1 codecarrier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@codecarrier1 codecarrier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhgomes bhgomes merged commit 0952c86 into main Jun 13, 2022
@bhgomes bhgomes deleted the feat/move-landing-page branch June 13, 2022 14:39
@bhgomes bhgomes added the L-added Changelog: add these changes to the `added` section of the changelog label Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants