Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/sbt extension #114

Merged
merged 116 commits into from
Apr 7, 2023
Merged

Feature/sbt extension #114

merged 116 commits into from
Apr 7, 2023

Conversation

DanielZhangReal
Copy link
Contributor

@DanielZhangReal DanielZhangReal commented Apr 4, 2023 •
edited
Loading

  • Refactor SDK logic
  • Add build SBT posts method and getIdentityProof
  • Add docs and examples on how to connect Manta Wallet
  • Add how to use SDK docs and examples

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

AlexParshh and others added 30 commits December 25, 2022 10:24
@AlexParshh
wip
f2ab8fc
@ferrell-code
add SBTWallet interface
7f39629 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
remove duplicate code
196d1f3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
add reserveSbt call
ebe35e3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@zqhxuyuan
single TransferPost and fix compile
6ff6ad2 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ferrell-code
fix metadata function
e625b72 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
add get metadata helper function
a350e88 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@zqhxuyuan
add sign_with_transaction_data
196333f 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan
use v0.5.9 and add transaction_data
c6ac955 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan
return transaction data when mintSBT
438b312 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ferrell-code
fix metadata bug in mintSbt
91be4ad 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix example
31da0e3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
Add identity proof to sdk
8cbe082 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix identity and do clippy lints
f5a1c15 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
add callback methods
4a95b08 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
make only build tx and change example
ba2bad7 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
remove duplicate ledger
969119a 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
change storage for sbt metadata
b61ca61 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@bhgomes
feat: add changelog and release system (#84)
16e5524 
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
@zqhxuyuan
add asset info of mint sbt result and verifiy feature
86de2ff 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@ferrell-code
back to using separate rpc
fe092fb 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
merge
c5fce2d 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix rpc used
e09f601 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@zqhxuyuan
fix asset id
84fdc8f 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
@zqhxuyuan
Merge branch 'fer-sbt-ledger' of github.com:Manta-Network/sdk into fe…
30f5ebc 
…r-sbt-ledger
@ferrell-code
fix get metadata
61df365 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@Kevingislason
init private wallet without connected api (#86)
65feea8 
* init private wallet without connected api

* update readme / examples

* bump version

* update changelog

* refactor check api is ready
@ferrell-code
merge to master
4d0d7b4 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@ferrell-code
fix broken merge
8436ce3 
Signed-off-by: Charles Ferrell <charlie@manta.network>
@zqhxuyuan
add sbt sdk readme
53e64e4 
Signed-off-by: zqhxuyuan <zqhxuyuan@gmail.com>
Apokalip
Apokalip previously approved these changes Apr 7, 2023
View reviewed changes
ghzlatarev
ghzlatarev previously approved these changes Apr 7, 2023
View reviewed changes
SupremoUGH
SupremoUGH previously requested changes Apr 7, 2023
View reviewed changes
manta-js/package/src/wallet/crate/src/lib.rs Outdated Show resolved Hide resolved
@Apokalip Apokalip self-requested a review April 7, 2023 12:05
@SupremoUGH SupremoUGH dismissed stale reviews from ghzlatarev and Apokalip via a0a24e7 April 7, 2023 12:54
@SupremoUGH SupremoUGH dismissed their stale review April 7, 2023 12:56

Conversation resolved. Somebody else should review the whole PR because it's mostly typescript.

Apokalip
Apokalip previously approved these changes Apr 7, 2023
View reviewed changes
ferrell-code
ferrell-code reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one future improvement that would be nice is to remove as many of the any as we can, but that can be future PR

manta-js/package/src/config.json Outdated Show resolved Hide resolved
ferrell-code
ferrell-code previously approved these changes Apr 7, 2023
View reviewed changes
SupremoUGH
SupremoUGH suggested changes Apr 7, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
manta-js/CHANGELOG.md Outdated Show resolved Hide resolved
@DanielZhangReal DanielZhangReal merged commit e10167b into signer_extension Apr 7, 2023
@DanielZhangReal DanielZhangReal deleted the feature/sbt_extension branch April 7, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SupremoUGH SupremoUGH SupremoUGH approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

@zqhxuyuan zqhxuyuan Awaiting requested review from zqhxuyuan

@bhgomes bhgomes Awaiting requested review from bhgomes

@Kevingislason Kevingislason Awaiting requested review from Kevingislason

@ghzlatarev ghzlatarev Awaiting requested review from ghzlatarev

@Apokalip Apokalip Awaiting requested review from Apokalip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@DanielZhangReal @Kevingislason @SupremoUGH @Apokalip @ghzlatarev @ferrell-code @AlexParshh @zqhxuyuan @bhgomes