Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pruning #118

Merged
merged 23 commits into from
Apr 28, 2023
Merged

Pruning #118

merged 23 commits into from
Apr 28, 2023

Conversation

SupremoUGH
Copy link
Contributor

@SupremoUGH SupremoUGH commented Apr 14, 2023 •
edited by DanielZhangReal
Loading

Changes:

  • Add pruning method
  • Fix the initial sync bug
  • Make the signer key logic more robust
  • Ledger reading errors now don't panic
  • Fix TransferPost WASM constructor
  • Refactor walletIsBusy logic
  • Add get transactionDatas from posts

Goes together with: Manta-Network/manta-rs#331

Before we can merge this PR, please make sure that all the following items have been checked off:

  • Linked to an issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Added one line describing your change in CHANGELOG.md and added the appropriate L- label to the PR.
  • Re-reviewed Files changed in the GitHub PR explorer.

@SupremoUGH SupremoUGH changed the base branch from main to signer_extension April 14, 2023 11:41
@SupremoUGH SupremoUGH mentioned this pull request Apr 14, 2023
Merged
4 tasks
@SupremoUGH SupremoUGH added the L-added Changelog: add these changes to the `added` section of the changelog label Apr 14, 2023
@DanielZhangReal DanielZhangReal marked this pull request as ready for review April 28, 2023 04:45
ferrell-code
ferrell-code approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@ferrell-code ferrell-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

manta-js/examples/extension-example/src/App.tsx Show resolved Hide resolved
@DanielZhangReal DanielZhangReal merged commit b5b6817 into signer_extension Apr 28, 2023
@DanielZhangReal DanielZhangReal deleted the pruning branch April 28, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqhxuyuan zqhxuyuan zqhxuyuan left review comments

@DanielZhangReal DanielZhangReal DanielZhangReal left review comments

@Apokalip Apokalip Apokalip approved these changes

@ghzlatarev ghzlatarev ghzlatarev approved these changes

@ferrell-code ferrell-code ferrell-code approved these changes

Assignees

@SupremoUGH SupremoUGH

@DanielZhangReal DanielZhangReal

Labels
L-added Changelog: add these changes to the `added` section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SupremoUGH @zqhxuyuan @Apokalip @ghzlatarev @ferrell-code @DanielZhangReal