Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map as standalone react component basic map #395

Merged
merged 13 commits into from
Oct 4, 2024
Merged

Map as standalone react component basic map #395

merged 13 commits into from
Oct 4, 2024

Conversation

ammapspeople
Copy link
Contributor

What

  • Create a new repo package, "react-components", containing a Vite+React setup made the same way as the Map Template.
  • Implement a MIMap component with two sub components MapboxMap and GoogleMapsMap.
    • The map will take MapsIndoors API key, map provider token and a center+zoom level and show a MapsIndoors map based on that.

andreeaceachir142
andreeaceachir142 approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@andreeaceachir142 andreeaceachir142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the clarifications. Approved ✅

@ammapspeople ammapspeople merged commit e2e76b2 into map-as-standalone-react-component Oct 4, 2024
@ammapspeople ammapspeople deleted the map-as-standalone-react-component--basic-map branch October 4, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreeaceachir142 andreeaceachir142 andreeaceachir142 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammapspeople @andreeaceachir142