Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite all examples to use impl Parser instead of parser! #156

Merged
merged 3 commits into from
May 10, 2018
Merged

Rewrite all examples to use impl Parser instead of parser! #156

merged 3 commits into from
May 10, 2018

Conversation

Marwes
Copy link
Owner

@Marwes Marwes commented May 10, 2018

🎉

@MaikKlein
Copy link

Are the explicit errors still necessary? https://github.com/Marwes/combine/pull/156/files#diff-f6193179f8a8135fa429d4786a78fd1bR60

@Marwes
Copy link
Owner Author

Marwes commented May 10, 2018 •
edited
Loading

Are the explicit errors still necessary? https://github.com/Marwes/combine/pull/156/files#diff-f6193179f8a8135fa429d4786a78fd1bR60

Yup :( https://github.com/Marwes/combine/pull/156/files#diff-f6193179f8a8135fa429d4786a78fd1bR46

rust-lang/rust#24159

@Marwes Marwes merged commit 7b2878e into master May 10, 2018
@Marwes Marwes deleted the impl_trait branch May 10, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marwes @MaikKlein