Fix default elevation of Card Flipper #2801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UI test fails because of the static ctor in FlipperAssist. I was unable to get this to work and may need some input on how to get it to locate the resource with the Uri when executing in the MaterialDesignThemes.UITests context.
|
Thank you. I fixed the issue by moving out the static loading of the resources into a separate class. This effectively defers loading of the resources until |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #2729
This fixes the broken default elevation of the (Card) Flipper. It was a simple matter of a default elevation not being set on the MaterialDesignCardFlipper style.
I added a UI test to ensure this default is applied, but it fails because of the static constructor in FlipperAssist. I was unable to get this to work and may need some input on how to get it to locate the resource with the Uri when executing in the MaterialDesignThemes.UITests context.