Update MaterialDesignTheme.MahApps for MahApps v1.6.5 #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any new news? |
ahmed-abdelrazek
approved these changes
Jun 8, 2018
Keboo
pushed a commit
that referenced
this pull request
Aug 12, 2018
* Updated Version of #898 that uses MahApps.Metro v1.6.5 * Fix for MahApps.NumericUpDown Controller * Fixing indentation * Fixing up nuspec changes. * Reving test projects and packet dependencies.
|
@punker76 can you check and update your list with the work that is still needed for this? |
Missing 'r' in 'library' and removed ',' in the sentence because a compound predicate composed of two objects shouldn’t be separated by a comma and a conjunction.
Simple Grammar Corrections
DatePicker Style: Added FloatingHint Trigger to change margin
Add context menu to password box to prevent ugly non-themed menu
Update MaterialDesignTheme.PasswordBox.xaml
Resolves the issue: #835
Shadow forces rerender in Cards #835
Fix text wrapping in DataGridColumnHeader
This allows the attached properties to be put on comboboxes and affect the hint. Currently it has the side affect of the hint being cut off when the combobox is expanded and the hint is too big.
Added Scale and Offset to the combobox template
Remove Header from default context menu in TextBox
Update ButtonProgressAssist.cs
Fix Thumb of GridViewColumnHeader.
Fix DialogHost and DrawerHost background fadeout
Updating ShowMeTheXaml to 1.0.10
Copy button display fix
Fix textbox cursor disappearing
Adding the zip support for the release branch as well
Moved DialogHost to its own dictionary. Alternate DialogHost style to embed the content as part of the visual tree.
Bumping version to 2.5.0
Add demo displaying issue Fixes #1001
* Updated Version of #898 that uses MahApps.Metro v1.6.5 * Fix for MahApps.NumericUpDown Controller * Fixing indentation * Fixing up nuspec changes. * Reving test projects and packet dependencies.
Styling ButtonBase instead of Button only
Changes:
TargetType="{x:Type Button}" -> TargetType="{x:Type ButtonBase}"
Property="IsDefaulted" -> Property="Button.IsDefaulted"
Working correctly for all buttons(based on ButtonBase)
IsDefaulted working for Button only
…ation templates (#911)
…esignUserForegroundCheckBox) and sync'd CheckBox changes (#983) * Added MaterialDesignUserForegroundRadioButton (same idea as MaterialDesignUserForegroundCheckBox) and sync'd CheckBox changes It's nice to have a RadioButton that can be used on any dark background so used same logic as MaterialDesignUserForegroundCheckBox. Also, there were a couple of tweaks in MaterialDesignCheckBox that didn't make it to MaterialDesignUserForegroundCheckBox so now it's in sync. * Moving the example into the cards page with the others
* change progress bar from border to a real progress bar on buttons with style MaterialDesignRaisedButton and MaterialDesignRaisedAccentButton * make opacity bindable * now realy bindable * bind IsIndicatorVisible to Visibility of Progressbar, add default values for opacity * fix MaterialDesignRaisedAccentButton is washed out * Minor cleanup of the examples.
When the double margin bug on cards were fixed it caused the shadow on dialogs to get cropped. Previously the default DialogMargin was 22, which when doubled left 44 units of space around the dialog's card (pleasnty for the 35 needed by shadow Depth5). But when that was cut it half the shadow was then clipped.
punker76
changed the title
Now user and Set the Listbox Background to Null to get a Fully transparent toolbar
The X2 binding is causing the textbox to never give up any width it's gotten. The visibility change makes it so it's only ever an issue if the textbox is disabled and the text is shortend programmatically.
punker76
changed the title
|
@Keboo I'm done. Sorry for the delay, needed some oss pause. These changes should now work with the latest stable MahApps version 1.6.5. /cc @ButchersBoy |
|
@punker76 looks great. Thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #901