Bugfix for accessing network printers #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driehle
changed the title
MatteoMeil
added a commit
that referenced
this pull request
Jun 3, 2019
|
Thank you very much for your work! I have not so much time to spend fixing bugs and improving my repo, so external help is always welcome and appreciate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
listPrinters()on Windows currently returns all printers installed, which may be either local printers or network printers. Sending documents there viaprint()also works withouth any problems. However, when callingprinterInfo()orprinterOptions()for a network printer (e.g., \\SOMEWHERE\PRINTER01), a System.Printing.PrintQueueException is thrown saying that the printer name is invalid.This PR solves this issue by splitting up the printer name into host name and printer when it starts with
\\. Then, the remote print server can be accesses withnew PrintServer(host)and everything works as intended. This also solves issue #10.