Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Use yarn pnp and zero-install #66

Open
MauriceNino opened this issue May 30, 2022 · 4 comments
Open

[Feature] Use yarn pnp and zero-install #66

MauriceNino opened this issue May 30, 2022 · 4 comments
Assignees
@MauriceNino
Labels
type: feature

Comments

@MauriceNino
Copy link
Owner

Description of the feature

Use yarn nodeLinker pnp instead of node-modules for faster CI and development.

Additional context

Blocked by #65
@MauriceNino MauriceNino self-assigned this May 30, 2022
@MauriceNino MauriceNino reopened this Jun 2, 2022
MauriceNino added a commit that referenced this issue Jun 2, 2022
@MauriceNino
chore(deps): switch back to pnp linker
bcb8bc7 
because we use semantic-release-plus instead of semantic-release now, we should not be limited by
chalk anymore

fix #66
@MauriceNino
Copy link
Owner Author

Reopened, because semantic-version-plus uses chalk which is known to break PNP.

Ref: chalk/chalk#531, yarnpkg/berry#3843

@MauriceNino
Copy link
Owner Author

Closed as not planned for now, because it isn't stable anyway.

@MauriceNino MauriceNino closed this as not planned Won't fix, can't repro, duplicate, stale Jun 9, 2022
@mrienstra
Copy link

FYI, yarnpkg/berry#3843 was fixed yesterday. The fix is available in 4.0.0-rc.22. Run yarn set version canary if you want to try it. v4 release is still a little ways off ("may take a couple more months"), but:

[...] what's in master is stable, and I'd recommend you to try it. The only notable difference with stable is that we reserve the right to land a couple more breaking changes in future RCs, but in terms of stability it's almost always better to use RCs than stable.

... according to yarnpkg/berry#4895

See yarnpkg/berry#3591 for v4 breaking changes. I've seen two mentions of people stumbling over enableGlobalCache default changing from false to true. (Google search: site:yarnpkg.com "enableGlobalCache")

@mrienstra
Copy link

Update: the fix that adds support for the package.json includes field is also in the Yarn 3.2.4 release.

@MauriceNino MauriceNino reopened this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MauriceNino MauriceNino

Labels
type: feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrienstra @MauriceNino