Skip to content

Commit

Permalink
[v2] Correct inlined css upgrade guide (gatsbyjs#5741)
Browse files Browse the repository at this point in the history
v1's default html.js also inlined css https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby/cache-dir/default-html.js

The change is that with mini-css-extract-plugin, we have css splitting so we handle inlining css in core as it requires understanding webpack's stats object.
  • Loading branch information
KyleAMathews authored and m-allanson committed Jun 5, 2018
1 parent d47bc58 commit dacc6b5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/docs/migrating-from-v1-to-v2.md
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,6 @@ See [Gatsby's webpack docs for more details](/docs/add-custom-webpack-config) ab

## Remove inlined CSS in `html.js`

Gatsby v2 automatically inlines CSS. Gatsby v1 required you to create a [custom `html.js` file](/docs/custom-html) to do this. You can remove any custom CSS inlining from your custom `html.js`, in many cases this allows you to completely remove your `html.js` file.
Gatsby v2 automatically inlines CSS. You can remove any custom CSS inlining from your custom `html.js`.

See an example in [this PR that upgrades the `using-remark` site to Gatsby v2](https://github.com/gatsbyjs/gatsby/commit/765b679cbc222fd5f527690427ee431cca7ccd61#diff-637c76e3c059ed8efacedf6e30de2d61).

0 comments on commit dacc6b5

Please sign in to comment.