spi_nand_flash: don't break the loop on erase fail #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NAND flash memories are allowed to contain some bad blocks, which fail to write or fail to erase. Currently, chip erase operation breaks on first failed block, leaving the rest of memory untouched. So, to do full chip erase with failed blocks, manual fiddling with addresses is needed. To avoid that, don't break the loop on erase fail, but keep the final error status.
|
Hi! In principle, it is logical to continue erasing process if a bad block is caught. I accept your fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAND flash memories are allowed to contain some bad blocks, which fail
to write or fail to erase. Currently, chip erase operation breaks on
first failed block, leaving the rest of memory untouched. So, to do full
chip erase with failed blocks, manual fiddling with addresses is needed.
To avoid that, don't break the loop on erase fail, but keep the final
error status.