Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discard settings for external controller in profiles #330

Closed
wants to merge 1 commit into from

Conversation

karin0
Copy link

@karin0 karin0 commented Sep 11, 2024

Profiles can contain insecure settings for external controllers, and having a default value in ConfigurationOverride didn't help because they wouldn't be serialized (#299 (comment)). This PR disables the external controller in the original profile before the override is applied, so that only the explicit override settings are retained.

@karin0
Copy link
Author

karin0 commented Sep 11, 2024

The main branch seems to have fixed it, but shall we clear ExternalControllerUnix and Secret to ensure all settings for external controller from the profile are cleared?

@wwqgtxx
Copy link

wwqgtxx commented Sep 11, 2024

ExternalControllerUnix will be restricted by Android's file permission management and cannot be accessed by third-party applications on non-ROOT platforms, so it does not pose a security issue.
As for Secret, if you directly clear the configuration file, it may cause some people to forget to manually set the password in the GUI, so it is a relatively good practice to keep reading the configuration file.

@karin0
Copy link
Author

karin0 commented Sep 11, 2024

Got it, thanks for the clarification!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants