-
-
Notifications
You must be signed in to change notification settings - Fork 178
Comparing changes
Open a pull request
base repository: MetaMask/core
base: v22.0.0
head repository: MetaMask/core
compare: v23.0.0
- 13 commits
- 39 files changed
- 6 contributors
Commits on Dec 6, 2021
-
[FEAT] Favorite Collectibles (#623)
Gustavo Antunes committedDec 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 53775d9 - Browse repository at this point
Copy the full SHA 53775d9View commit details -
Add caller-specified error for ApprovalController.clear (#656)
`ApprovalController.clear` rejects all pending approvals and clears the state of the controller. This PR adds a "rejection error" parameter to the `clear` method and removes the default error. We decided that there is no reasonable default for this method, since `clear` may be called for a variety of different reasons.
Configuration menu - View commit details
-
Copy full SHA for 2570553 - Browse repository at this point
Copy the full SHA 2570553View commit details
Commits on Dec 10, 2021
-
Extract determineGasFeeCalculations (#612)
We would like to introduce another fallback to how we estimate gas fees in a future commit — namely, we want to use `eth_feeHistory` for EIP-1559 networks if the usual API is down. To do this, the existing code around gas fee estimates needs to be refactored. This is the first in a two-part refactor, extracting the majority of the code in `GasFeeController._fetchGasFeeEstimateData` to `gas-util`. In addition to making room for more changes, this also allows us to test this code in isolation from the polling code that already exists in GasFeeController. Note that I am using the term "calculations" to encompass the data that `_fetchGasFeeEstimateData` returns. This is because `gasFeeEstimates` is an intermediate value that can also be packaged with `estimatedGasFeeTimeBounds`, so "estimates" could be confusing. Also, I replaced "fetch" with "determine" as in the future we may be performing calculations that APIs have done for us in the past ("fetch" seems like a more low-level action).
Configuration menu - View commit details
-
Copy full SHA for 215a879 - Browse repository at this point
Copy the full SHA 215a879View commit details -
Use eth_feeHistory as a fallback for gas estimates (#614)
If we are on an EIP-1559-supported network and the Metaswap API fails for some reason, fall back to using `eth_feeHistory` to calculate gas estimates (which the API uses anyway). This code is more or less taken from the code for the API ([1]). [1]: https://gitlab.com/ConsenSys/codefi/products/metaswap/gas-api/-/blob/eae6927b1a0c445e02cb3cba9e9e6b0f35857a12/src/eip1559/feeHistory.ts
Configuration menu - View commit details
-
Copy full SHA for 7e42380 - Browse repository at this point
Copy the full SHA 7e42380View commit details -
Pull in networkCongestion along with gas estimates (#632)
The Metaswap API now includes a `networkCongestion` property when requesting EIP-1559-compatible gas fee estimates. This value, which is a number from 0 to 1, where 0 represents "not congested" and 1 represents "extremely congested", can be used to communicate the status of the network to users when they are sending transactions. This commit ensures that GasFeeController includes `networkCongestion` as part of the state it persists, no matter if using the Metaswap API to obtain this information or falling back to `eth_feeHistory`. This is a part of the EIP-1559 v2 work.
Configuration menu - View commit details
-
Copy full SHA for 778371c - Browse repository at this point
Copy the full SHA 778371cView commit details -
Refactor EIP-1559 v2 fallback code to ease expansion (#640)
In future commits we will bring in more gas fee related data points from the MetaSwap API. When we do this, we will have to implement fallbacks for all of these data points. Every data point is different and will require a different strategy and different testing. This commit breaks up the existing fallback code so this is a lot easier to do.
Configuration menu - View commit details
-
Copy full SHA for bf37d4c - Browse repository at this point
Copy the full SHA bf37d4cView commit details -
Pull in remaining EIP-1559 v2 datapoints (#646)
Several new properties are now available from the `/suggestedGasFees` endpoint in the MetaSwap API. This commit updates GasFeeController to store these properties in state when polling for gas fee estimates and implements fallback code for the underlying datapoints. This way we can use these values to display different UI elements to users when they are sending transactions. The properties are: * `historicalBaseFeeRange` — minimum and maximum values for the base fees over the past 200 blocks * `baseFeeTrend` — an indicator for which direction the base fee is moving based on the current pending block vs. the latest block * `latestPriorityFeeRange` — minimum and maximum values for the priority fees in the latest block * `historicalPriorityFeeRange` — minimum and maximum values for priority fees over the past 200 blocks * `priorityFeeTrend` — an indicator for which direction priority fees are moving based on the current pending block vs. the latest block
Configuration menu - View commit details
-
Copy full SHA for d2d1542 - Browse repository at this point
Copy the full SHA d2d1542View commit details -
Add finish to EIP-1559 v2 gas estimate code (#660)
After integration-testing both the fallback and non-fallback code responsible for pulling gas fee estimates, there were a few fixes needed: * `ethQuery.latestBlock()` was not being called correctly. * For some datapoints, we need to pull the estimated base fee for the next block. This adds an `includeNextBlock` option to `fetchBlockFeeHistory` so that this is possible. It also splits the `FeeHistoryBlock` type into two types, because the next block won't have information about gas used ratios or priority fees (because there is no transaction data associated with the next block, as it doesn't exist). * One of the allowed values for the `endBlock` argument to `fetchBlockFeeHistory` was "pending". This breaks `fetchBlockFeeHistory`, so this has been removed. * Some of the datapoints were based on the wrong data, so this has been corrected as well.
Configuration menu - View commit details
-
Copy full SHA for 0c2dbe2 - Browse repository at this point
Copy the full SHA 0c2dbe2View commit details
Commits on Dec 13, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 09a1ea6 - Browse repository at this point
Copy the full SHA 09a1ea6View commit details
Commits on Dec 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 3277603 - Browse repository at this point
Copy the full SHA 3277603View commit details
Commits on Dec 17, 2021
-
add updateNestedCollectibleState to clean up redundant nested state u…
…pdate logic (#665) * add updateNestedCollectibleState to clean up redundant nested state update logic * address feedback
Configuration menu - View commit details
-
Copy full SHA for be94b9b - Browse repository at this point
Copy the full SHA be94b9bView commit details -
Add method to check and update collectible ownership state (#664)
* Add method to check and update collectible ownership state
Configuration menu - View commit details
-
Copy full SHA for 5aaf511 - Browse repository at this point
Copy the full SHA 5aaf511View commit details
Commits on Dec 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 45fa757 - Browse repository at this point
Copy the full SHA 45fa757View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v22.0.0...v23.0.0