add updateNestedCollectibleState to clean up redundant nested state update logic #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
updateNestedCollectibleState
branch
from
0ca9545
to
e8933a4
Compare
adonesky1
force-pushed
the
updateNestedCollectibleState
branch
from
e8933a4
to
f5c0441
Compare
wachunei
approved these changes
Dec 16, 2021
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…pdate logic (#665) * add updateNestedCollectibleState to clean up redundant nested state update logic * address feedback
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…pdate logic (#665) * add updateNestedCollectibleState to clean up redundant nested state update logic * address feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADDED:
updateNestedCollectibleStateto clean up redundant nested state update logic in various methods in the CollectiblesController.