Remove ESLint jest/valid-expect-in-promise #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
requested changes
Mar 23, 2021
Gudahtt
previously approved these changes
Mar 25, 2021
| }); | ||
| controller.cancelTransaction(controller.state.transactions[0].id); | ||
| result.catch((error) => { | ||
| expect(error.message).toContain('User rejected the transaction'); | ||
| resolve(''); |
There was a problem hiding this comment.
Nit: we don't need to pass anything to resolve here.
Suggested change
| resolve(''); | |
| resolve(); |
There was a problem hiding this comment.
Bah. I committed this, but now the test fails because the type needs to be adjusted. I'm going to undo this for now - we can fix it some other time.
Gudahtt
force-pushed
the
refactor-jest-async-await
branch
from
1382ec8
to
56c1c91
Compare
Gudahtt
approved these changes
Apr 7, 2021
|
I decided to go ahead and merge this now, to reduce the chance of future conflicts |
Gudahtt
added a commit
that referenced
this pull request
Apr 15, 2021
- Add restricted controller messenger ([#378](#378)) - **BREAKING:** Update minimum Node.js version to v12 ([#441](#441)) - **BREAKING:** Replace controller context ([#387](#387)) - Bump @metamask/contract-metadata from 1.23.0 to 1.24.0 ([#440](#440)) - Update lint rules ([#442](#442), [#426](#426)) - Don't remove collectibles during auto detection ([#439](#439))
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* refactor catch errors to async await format * finish promise callback removal * restore ordering * promise does not resolve * use listener to ensure expects are called Co-authored-by: Mark Stacey <markjstacey@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* refactor catch errors to async await format * finish promise callback removal * restore ordering * promise does not resolve * use listener to ensure expects are called Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the way the tests catch errors. Currently they are wrapped in promises, but instead it can be refactored to use a jest trick of await expect(function).rejects.toThrow('error message'). Using this trick, we can remove this lint rule.