Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ESLint jest/valid-expect-in-promise #426

Merged
merged 6 commits into from
Apr 7, 2021
Merged

Remove ESLint jest/valid-expect-in-promise #426

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2c92d6
refactor catch errors to async await format
astarinmymind Mar 23, 2021
4b13a48
finish promise callback removal
astarinmymind Mar 23, 2021
4263bd0
restore ordering
astarinmymind Mar 23, 2021
41eb582
promise does not resolve
astarinmymind Mar 23, 2021
56c1c91
use listener to ensure expects are called
astarinmymind Mar 24, 2021
d3a43c0
Merge branch 'develop' into refactor-jest-async-await
Gudahtt Apr 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
restore ordering
  • Loading branch information
@astarinmymind
astarinmymind committed Mar 23, 2021
commit 4263bd0e478fcf3a0b67afe3e321053702a90d33
46 changes: 23 additions & 23 deletions src/transaction/TransactionController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,25 +661,25 @@ describe('TransactionController', () => {
});

it('should fail to approve an invalid transaction', async () => {
const controller = new TransactionController({
provider: PROVIDER,
sign: () => {
throw new Error('foo');
},
});
controller.context = {
NetworkController: MOCK_NETWORK,
} as any;
controller.onComposed();
const from = '0xe6509775f3f3614576c0d83f8647752f87cd6659';
const to = '0xc38bf1ad06ef69f0c04e29dbeb4152b4175f0a8d';
const { result } = await controller.addTransaction({ from, to });
const { transaction, status } = controller.state.transactions[0];
expect(transaction.from).toBe(from);
expect(transaction.to).toBe(to);
expect(status).toBe(TransactionStatus.unapproved);
await controller.approveTransaction(controller.state.transactions[0].id);
await expect(result).rejects.toThrow('foo');
const controller = new TransactionController({
provider: PROVIDER,
sign: () => {
throw new Error('foo');
},
});
controller.context = {
NetworkController: MOCK_NETWORK,
} as any;
controller.onComposed();
const from = '0xe6509775f3f3614576c0d83f8647752f87cd6659';
const to = '0xc38bf1ad06ef69f0c04e29dbeb4152b4175f0a8d';
const { result } = await controller.addTransaction({ from, to });
await controller.approveTransaction(controller.state.transactions[0].id);
const { transaction, status } = controller.state.transactions[0];
expect(transaction.from).toBe(from);
expect(transaction.to).toBe(to);
expect(status).toBe(TransactionStatus.failed);
await expect(result).rejects.toThrow('foo');
});

it('should fail transaction if gas calculation fails', async () => {
Expand Down Expand Up @@ -714,11 +714,11 @@ describe('TransactionController', () => {
const from = '0xe6509775f3f3614576c0d83f8647752f87cd6659';
const to = '0xc38bf1ad06ef69f0c04e29dbeb4152b4175f0a8d';
const { result } = await controller.addTransaction({ from, to });
await controller.approveTransaction(controller.state.transactions[0].id);
const { transaction, status } = controller.state.transactions[0];
expect(transaction.from).toBe(from);
expect(transaction.to).toBe(to);
expect(status).toBe(TransactionStatus.unapproved);
await controller.approveTransaction(controller.state.transactions[0].id);
expect(status).toBe(TransactionStatus.failed);
await expect(result).rejects.toThrow('No sign method defined');
});

Expand All @@ -734,11 +734,11 @@ describe('TransactionController', () => {
const from = '0xe6509775f3f3614576c0d83f8647752f87cd6659';
const to = '0xc38bf1ad06ef69f0c04e29dbeb4152b4175f0a8d';
const { result } = await controller.addTransaction({ from, to });
await controller.approveTransaction(controller.state.transactions[0].id);
const { transaction, status } = controller.state.transactions[0];
expect(transaction.from).toBe(from);
expect(transaction.to).toBe(to);
expect(status).toBe(TransactionStatus.unapproved);
await controller.approveTransaction(controller.state.transactions[0].id);
expect(status).toBe(TransactionStatus.failed);
await expect(result).rejects.toThrow('No chainId defined');
});

Expand Down