Fix issues with empty responses in ERC20Standard #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
* Fix an issue with empty ERC20 responses in ERC20Standard * Add comment * One more comment
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix an issue with empty ERC20 responses in ERC20Standard * Add comment * One more comment
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Fix an issue with empty ERC20 responses in ERC20Standard * Add comment * One more comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some issues with ERC20Standard and proxy contracts. Some proxy contracts return
0xinstead of reverting when an unknown method signature is used. This PR adds requirements forsymbol()anddecimals()to be non-empty.Itemize the changes you have made into the categories below
FIXED:
Checklist
Issue
Fixes MetaMask/metamask-extension#16076