Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues with empty responses in ERC20Standard #927

Merged
merged 4 commits into from
Oct 5, 2022
Merged

Fix issues with empty responses in ERC20Standard #927

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6ea628e
Fix an issue with empty ERC20 responses in ERC20Standard
FrederikBolding Oct 5, 2022
8cea7cb
Add comment
FrederikBolding Oct 5, 2022
424ae03
One more comment
FrederikBolding Oct 5, 2022
12e9925
Merge branch 'main' into fb/fix-erc20-empty-responses
FrederikBolding Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@FrederikBolding
FrederikBolding committed Oct 5, 2022
commit 8cea7cb5207d14412170a621237f5dbf135db51c
1 change: 1 addition & 0 deletions src/assets/Standards/ERC20Standard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export class ERC20Standard {
}

const resultString = result.toString();
// We treat empty string or 0 as invalid
if (resultString.length > 0 && resultString !== '0') {
resolve(resultString);
}
Expand Down