Make both callback and messaging system options for TokenListController & GasFeeController when listening to NetworkController
#932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
changed the title
Gudahtt
reviewed
Oct 11, 2022
Gudahtt
reviewed
Oct 11, 2022
adonesky1
changed the title
TokenListController & GasFeeController when listening to NetworkController
adonesky1
changed the title
TokenListController & GasFeeController when listening to NetworkControllerTokenListController & GasFeeController when listening to NetworkController
Gudahtt
reviewed
Oct 11, 2022
Gudahtt
reviewed
Oct 11, 2022
adonesky1
force-pushed
the
revert-tokenListController-messaging
branch
from
5dd4cf6
to
6d87362
Compare
|
We talked on Slack and decided to postpone the testing until later. The tests for that controller are in rough shape, and this functionality was already untested. |
Merged
gantunesr
pushed a commit
that referenced
this pull request
Dec 8, 2022
…ler` & `GasFeeController` when listening to `NetworkController` (#932) * support either callback or messaging system subscription for NetworkController on GasFeeController and TokenListController
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ler` & `GasFeeController` when listening to `NetworkController` (#932) * support either callback or messaging system subscription for NetworkController on GasFeeController and TokenListController
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…ler` & `GasFeeController` when listening to `NetworkController` (#932) * support either callback or messaging system subscription for NetworkController on GasFeeController and TokenListController
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIXED:
onNetworkStateChangedcallback was mistakenly removed fromTokenListControllerin v32.0.0. It is now added back and is available as an option alongside a messaging system subscription for syncing withNetworkControllerupdates