Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make both callback and messaging system options for TokenListController & GasFeeController when listening to NetworkController #932

Merged
merged 11 commits into from
Oct 12, 2022
Merged

Make both callback and messaging system options for TokenListController & GasFeeController when listening to NetworkController #932

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
92bf61a
revert changes to TokenListController introduced in NetworkController…
adonesky1 Oct 11, 2022
e5971e9
support either callback or messaging system subscription
adonesky1 Oct 11, 2022
0947243
nit
adonesky1 Oct 11, 2022
29020fd
add jsDoc comments + make onNetworkStateChangeCallback private
adonesky1 Oct 11, 2022
c72ded1
support either callback or messaging system subscription for NetworkC…
adonesky1 Oct 11, 2022
79f0c9a
lint
adonesky1 Oct 11, 2022
6b56203
fix types/test
adonesky1 Oct 11, 2022
a9e060c
more fixes
adonesky1 Oct 11, 2022
8d084e1
add new TokenListController test
adonesky1 Oct 11, 2022
28c8217
tiny cleanup
adonesky1 Oct 11, 2022
6d87362
more cleanup
adonesky1 Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix types/test
  • Loading branch information
@adonesky1
adonesky1 committed Oct 11, 2022
commit 6b5620313d51ceff8238d6c23353dd057b354442
4 changes: 2 additions & 2 deletions src/gas/GasFeeController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,8 @@ export class GasFeeController extends BaseController<
getCurrentNetworkEIP1559Compatibility: () => Promise<boolean>;
getCurrentNetworkLegacyGasAPICompatibility: () => boolean;
getCurrentAccountEIP1559Compatibility?: () => boolean;
getChainId: () => `0x${string}` | `${number}` | number;
getProvider: () => NetworkController['provider'];
getChainId?: () => `0x${string}` | `${number}` | number;
getProvider?: () => NetworkController['provider'];
onNetworkStateChange?: (listener: (state: NetworkState) => void) => void;
legacyAPIEndpoint?: string;
EIP1559APIEndpoint?: string;
Expand Down