Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/core
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v27.1.1
Choose a base ref
...
head repository: MetaMask/core
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v28.0.0
Choose a head ref
  • 12 commits
  • 32 files changed
  • 9 contributors

Commits on Mar 30, 2022

  1. Copy .gitattributes from template repo (#760)

    This normalizes line endings and instructs GitHub not to collapse
    `yarn.lock`.
    mcmire committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    b9a1fbe View commit details
    Browse the repository at this point in the history
  2. Improve support for backfilling types via .d.ts's (#732)

    Currently, we exclude test files from TypeScript's purview, so that only
    files in `src/` get emitted to `dist/`. This makes sense from a release
    perspective, but it interferes with development.
    
    One example of this interference involves [ambient modules][1]. We have
    a file `dependencies.d.ts` which we can use to backfill missing types
    for various dependencies. The problem is that while TypeScript (or, more
    accurately, `tsserver`) can see the types specified here when reading
    source files, it doesn't seem to pick them up for test files. This
    causes in-editor inconsistencies with type analysis and, in some cases,
    warnings such as:
    
    * `import` can only be used with `esInteropModuleFlag: true`
    * `X` is missing type definitions
    
    The reason this is happening is that type definition files are not
    intended to just be placed in the source directory. You can either use
    triple-slash directives to bring them in, or you can modify a setting in
    `tsconfig.json` (`paths`) that will [instruct TypeScript where it should
    find types for modules that are imported][1]. This commit chooses the
    latter option. Note that this requires we split up `dependencies.d.ts`
    into separate type definition files, one per module.
    
    In addition to modifying `tsconfig.json`, this commit also breaks up
    this config file into a global/development version and a version that is
    specific to the build/release process. This allows editors to use
    the same exact TypeScript settings for test files as for non-test files.
    `tsconfig.build.json` is used by `yarn build` and will limit the files
    emitted to `dist/` to only non-test files in `src/`, as in the original
    configuration.
    
    [1]: https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules
    [2]: https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping
    mcmire committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    6f3808b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2022

  1. Fix inclusion of module-augmenting .d.ts's (#761)

    A previous commit updated the TypeScript configuration so TypeScript
    would better recognize type definition files whose purpose was to
    backfill types for existing packages. After testing, this revealed a
    misunderstanding of the `paths` option in `tsconfig.json`.
    
    It turns out that `paths` completely overrides how TypeScript resolves
    modules and locates type definition files for modules. The consequence
    of this option is that if a module includes type definitions, but we
    also supply type definitions for that module in `types/`, then our type
    definitions will win. This degrades the developer experience: sometimes,
    a package already has types, but we merely need to *augment* those
    types in some way. The `paths` option makes it impossible to do this.
    
    This commit keeps the `types/` directory (as it'll be important later)
    but informs TypeScript about the type definition files here by adding
    them to the `include` option in `tsconfig.json` (which was the original
    strategy).
    mcmire committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5f2d51c View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. Configuration menu
    Copy the full SHA
    f4404bc View commit details
    Browse the repository at this point in the history
  2. Add PermissionController.revokePermissionForAllSubjects action (#764)

    Adds a controller messenger action for `PermissionController.revokePermissionForAllSubjects`. We currently call the underlying function directly in the extension, but we'd like to encapsulate that call in the `SnapController`, which is where it should occur.
    rekmarks committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    3391089 View commit details
    Browse the repository at this point in the history
  3. BREAKING: Rename NotificationController to AnnouncementController (#697)

    * Rename NotificationController to AnnouncementController
    
    * Rename public exports
    
    * Fix build
    
    * Fix test
    
    * Replace every mention of notifications
    FrederikBolding committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    731246a View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. Add npm publish (#737)

    * add npm publish
    
    * address lint
    
    * move everything into `publish-release`
    
    * update to use v1
    
    * only cache and publish
    
    * Update .github/workflows/publish-release.yml
    
    * add npm publish
    
    * address lint
    
    * move everything into `publish-release`
    
    * update to use v1
    
    * only cache and publish
    
    * version needs to be explicit
    
    * exclude node_modules
    
    * use cache@v3
    
    * only cache ./dist
    
    * use sha
    
    * change environment to `npm-publish`
    rickycodes committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    91b8435 View commit details
    Browse the repository at this point in the history
  2. Fix typo in TransactionController.ts (#775)

    Attemps -> Attempts
    eltociear committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    41a5238 View commit details
    Browse the repository at this point in the history
  3. Use github.sha for publish jobs (#776)

    * use github.sha
    
    * ignore-scripts
    
    * Update .github/workflows/publish-release.yml
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    rickycodes and Gudahtt committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e4925ee View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Added GrantPermissions action to PermissionsController (#780)

    * Added GrantPermissions action to PermissionsController
    
    * Added test for PermissionController:grantPermissions action
    ritave committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    e4d59b6 View commit details
    Browse the repository at this point in the history
  2. Update publish instructions (#779)

    * Update publish instructions
    
    * Update README.md
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    
    * remove 8
    
    * add hyperlink
    
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    rickycodes and Gudahtt committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    0775f25 View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. 28.0.0 (#781)

    * 28.0.0
    
    * Update v28.0.0 changelog
    
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Mark Stacey <markjstacey@gmail.com>
    3 people committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    afc6ee7 View commit details
    Browse the repository at this point in the history
Loading