-
-
Notifications
You must be signed in to change notification settings - Fork 178
Comparing changes
Open a pull request
base repository: MetaMask/core
base: v27.1.1
head repository: MetaMask/core
compare: v28.0.0
- 12 commits
- 32 files changed
- 9 contributors
Commits on Mar 30, 2022
-
Copy .gitattributes from template repo (#760)
This normalizes line endings and instructs GitHub not to collapse `yarn.lock`.
Configuration menu - View commit details
-
Copy full SHA for b9a1fbe - Browse repository at this point
Copy the full SHA b9a1fbeView commit details -
Improve support for backfilling types via .d.ts's (#732)
Currently, we exclude test files from TypeScript's purview, so that only files in `src/` get emitted to `dist/`. This makes sense from a release perspective, but it interferes with development. One example of this interference involves [ambient modules][1]. We have a file `dependencies.d.ts` which we can use to backfill missing types for various dependencies. The problem is that while TypeScript (or, more accurately, `tsserver`) can see the types specified here when reading source files, it doesn't seem to pick them up for test files. This causes in-editor inconsistencies with type analysis and, in some cases, warnings such as: * `import` can only be used with `esInteropModuleFlag: true` * `X` is missing type definitions The reason this is happening is that type definition files are not intended to just be placed in the source directory. You can either use triple-slash directives to bring them in, or you can modify a setting in `tsconfig.json` (`paths`) that will [instruct TypeScript where it should find types for modules that are imported][1]. This commit chooses the latter option. Note that this requires we split up `dependencies.d.ts` into separate type definition files, one per module. In addition to modifying `tsconfig.json`, this commit also breaks up this config file into a global/development version and a version that is specific to the build/release process. This allows editors to use the same exact TypeScript settings for test files as for non-test files. `tsconfig.build.json` is used by `yarn build` and will limit the files emitted to `dist/` to only non-test files in `src/`, as in the original configuration. [1]: https://www.typescriptlang.org/docs/handbook/modules.html#ambient-modules [2]: https://www.typescriptlang.org/docs/handbook/module-resolution.html#path-mapping
Configuration menu - View commit details
-
Copy full SHA for 6f3808b - Browse repository at this point
Copy the full SHA 6f3808bView commit details
Commits on Apr 5, 2022
-
Fix inclusion of module-augmenting .d.ts's (#761)
A previous commit updated the TypeScript configuration so TypeScript would better recognize type definition files whose purpose was to backfill types for existing packages. After testing, this revealed a misunderstanding of the `paths` option in `tsconfig.json`. It turns out that `paths` completely overrides how TypeScript resolves modules and locates type definition files for modules. The consequence of this option is that if a module includes type definitions, but we also supply type definitions for that module in `types/`, then our type definitions will win. This degrades the developer experience: sometimes, a package already has types, but we merely need to *augment* those types in some way. The `paths` option makes it impossible to do this. This commit keeps the `types/` directory (as it'll be important later) but informs TypeScript about the type definition files here by adding them to the `include` option in `tsconfig.json` (which was the original strategy).
Configuration menu - View commit details
-
Copy full SHA for 5f2d51c - Browse repository at this point
Copy the full SHA 5f2d51cView commit details
Commits on Apr 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f4404bc - Browse repository at this point
Copy the full SHA f4404bcView commit details -
Add
PermissionController.revokePermissionForAllSubjects
action (#764)Adds a controller messenger action for `PermissionController.revokePermissionForAllSubjects`. We currently call the underlying function directly in the extension, but we'd like to encapsulate that call in the `SnapController`, which is where it should occur.
Configuration menu - View commit details
-
Copy full SHA for 3391089 - Browse repository at this point
Copy the full SHA 3391089View commit details -
BREAKING: Rename NotificationController to AnnouncementController (#697)
* Rename NotificationController to AnnouncementController * Rename public exports * Fix build * Fix test * Replace every mention of notifications
Configuration menu - View commit details
-
Copy full SHA for 731246a - Browse repository at this point
Copy the full SHA 731246aView commit details
Commits on Apr 8, 2022
-
* add npm publish * address lint * move everything into `publish-release` * update to use v1 * only cache and publish * Update .github/workflows/publish-release.yml * add npm publish * address lint * move everything into `publish-release` * update to use v1 * only cache and publish * version needs to be explicit * exclude node_modules * use cache@v3 * only cache ./dist * use sha * change environment to `npm-publish`
Configuration menu - View commit details
-
Copy full SHA for 91b8435 - Browse repository at this point
Copy the full SHA 91b8435View commit details -
Configuration menu - View commit details
-
Copy full SHA for 41a5238 - Browse repository at this point
Copy the full SHA 41a5238View commit details -
Use
github.sha
for publish jobs (#776)* use github.sha * ignore-scripts * Update .github/workflows/publish-release.yml Co-authored-by: Mark Stacey <markjstacey@gmail.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for e4925ee - Browse repository at this point
Copy the full SHA e4925eeView commit details
Commits on Apr 13, 2022
-
Added GrantPermissions action to PermissionsController (#780)
* Added GrantPermissions action to PermissionsController * Added test for PermissionController:grantPermissions action
Configuration menu - View commit details
-
Copy full SHA for e4d59b6 - Browse repository at this point
Copy the full SHA e4d59b6View commit details -
Update publish instructions (#779)
* Update publish instructions * Update README.md Co-authored-by: Mark Stacey <markjstacey@gmail.com> * remove 8 * add hyperlink Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 0775f25 - Browse repository at this point
Copy the full SHA 0775f25View commit details
Commits on Apr 14, 2022
-
* 28.0.0 * Update v28.0.0 changelog Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Mark Stacey <markjstacey@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for afc6ee7 - Browse repository at this point
Copy the full SHA afc6ee7View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v27.1.1...v28.0.0