Added GrantPermissions action to PermissionsController #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gudahtt
requested changes
Apr 13, 2022
|
@Gudahtt Explained the context in the PR description. Added a test as well |
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added GrantPermissions action to PermissionsController * Added test for PermissionController:grantPermissions action
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* Added GrantPermissions action to PermissionsController * Added test for PermissionController:grantPermissions action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to allow a new UI page for Snaps. We want to ask the user for approval for an update, showing new permissions on the same page. This will be implemented as a new ApprovalController request in SnapController and then call to grantPermissions in PermissionController. Related PR: MetaMask/snaps#322