Start end approval flows #1394
Merged
Start end approval flows #1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergarces
commented
Jun 7, 2023
| this.update((draftState) => { | ||
| draftState.pendingApprovals = {}; | ||
| draftState.pendingApprovalCount = 0; | ||
| }); |
There was a problem hiding this comment.
This has to do with mobile, since I couldn't find any instances of clear within the extension or snaps code.
When requesting a user approval in mobile, ApprovalController.clear() is called to remove all pending approvals.
If we don't stop it from clearing approval flows, it will also stop them in between approvals.
Other alternatives include an option in the requestUserApproval function to stop calling clear at will (defaulting to the current behaviour).
OGPoyraz
previously approved these changes
Jun 8, 2023
matthewwalsh0
approved these changes
Jun 9, 2023
OGPoyraz
approved these changes
Jun 9, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds methods to start and end an approval flow.
Changes
startFlowandendFlowmethods toApprovalController.References
Checklist