Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: message manager #160

Merged
merged 7 commits into from
Oct 17, 2019
Merged

Feature: message manager #160

merged 7 commits into from
Oct 17, 2019

Conversation

estebanmino
Copy link
Contributor

Adds support for eth_sign adding a new controller MessageManager, and updating an AbstractManagerController to other manager controllers.

@codecov-io
Copy link

codecov-io commented Oct 7, 2019

Codecov Report

Merging #160 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           develop   #160   +/-   ##
======================================
  Coverage      100%   100%           
======================================
  Files           22     23    +1     
  Lines         1472   1497   +25     
  Branches       207    209    +2     
======================================
+ Hits          1472   1497   +25
Impacted Files Coverage Δ
src/message-manager/PersonalMessageManager.ts 100% <100%> (ø) ⬆️
src/message-manager/TypedMessageManager.ts 100% <100%> (ø) ⬆️
src/message-manager/AbstractMessageManager.ts 100% <100%> (ø)
src/message-manager/MessageManager.ts 100% <100%> (ø) ⬆️
src/util.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 466549a...1fe81f3. Read the comment docs.

brunobar79
brunobar79 previously approved these changes Oct 7, 2019
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 🔥 !

@estebanmino estebanmino merged commit 340799c into develop Oct 17, 2019
@whymarrh whymarrh deleted the feature/message-manager branch November 5, 2019 17:44
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* abstract message manager

* update to abst manager

* message test

* update test

* validate sign message

* update docs
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
* abstract message manager

* update to abst manager

* message test

* update test

* validate sign message

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants