Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/catch for assetsContract.getBalanceOf #328

Merged
merged 11 commits into from
Jan 22, 2021

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Jan 19, 2021

@rickycodes rickycodes requested a review from a team as a code owner January 19, 2021 22:49
Gudahtt
Gudahtt previously approved these changes Jan 21, 2021
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/TokenBalancesController.test.ts Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@rickycodes rickycodes merged commit 9169e2b into develop Jan 22, 2021
@rickycodes rickycodes deleted the bugfix/token-balance-shows-0 branch January 22, 2021 16:22
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants