Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types field in package.json for all packages #4047

Merged
merged 1 commit into from
Mar 13, 2024
Merged

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Mar 13, 2024

Explanation

The types field in package.json was still pointing to ./dist/index.d.ts, but that file is now ./dist/types/index.d.ts. This causes type errors when using these packages with <Node16 module resolution.

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@Mrtenz Mrtenz requested review from a team as code owners March 13, 2024 10:32
Copy link

socket-security bot commented Mar 13, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@keystonehq/bc-ur-registry-eth@0.9.1 environment Transitive: eval, filesystem +74 9.63 MB soralit

View full report↗︎

Copy link

socket-security bot commented Mar 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@keystonehq/bc-ur-registry@0.5.5

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@Mrtenz
Copy link
Member Author

Mrtenz commented Mar 13, 2024

@SocketSecurity ignore npm/@keystonehq/bc-ur-registry@0.5.5

New author seems ok.

@Mrtenz Mrtenz merged commit 2bda188 into main Mar 13, 2024
139 checks passed
@Mrtenz Mrtenz deleted the mrtenz/fix-types-field branch March 13, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants