Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump TypeScript version to ~4.9.5 #4084

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Bump TypeScript version to ~4.9.5 #4084

merged 2 commits into from
Mar 20, 2024

Conversation

MajorLift
Copy link
Contributor

@MajorLift MajorLift commented Mar 19, 2024 •
edited
Loading

Explanation

As part of the Shared Libraries Q2 2024 OKRs (O3/KR4), this commit upgrades the TypeScript versions in all core repo packages to v4.9.

References

Changelog

@metamask/*

Changed

  • Update TypeScript to ~4.9.5 (#4084)

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@socket-security Socket Security
Copy link

socket-security bot commented Mar 19, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/typescript@4.9.5 None 0 66.8 MB typescript-bot

🚮 Removed packages: npm/typescript@4.8.4

View full report↗︎

@MajorLift MajorLift force-pushed the 240319-upgrade-typescript-4.9 branch from c659ba8 to 6d1eae1 Compare March 19, 2024 19:44
@MajorLift MajorLift self-assigned this Mar 19, 2024
@MajorLift MajorLift marked this pull request as ready for review March 19, 2024 20:34
@MajorLift MajorLift requested review from a team as code owners March 19, 2024 20:34
mcmire
mcmire approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MajorLift MajorLift merged commit ba6122a into main Mar 20, 2024
139 checks passed
@MajorLift MajorLift deleted the 240319-upgrade-typescript-4.9 branch March 20, 2024 14:59
@Gudahtt Gudahtt mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmire mcmire mcmire approved these changes

@Mrtenz Mrtenz Mrtenz approved these changes

@legobeat legobeat legobeat approved these changes

Assignees

@MajorLift MajorLift

Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to TypeScript v4.9
4 participants
@MajorLift @mcmire @Mrtenz @legobeat