Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eth-keyring-controller #460

Merged
merged 2 commits into from
May 13, 2021

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented May 4, 2021

Open as a Draft for now (I still need to test).

tested these changes on v8.0.0 in the mobile app and everything appears to be working

re: MetaMask/metamask-mobile#2620

@rickycodes rickycodes force-pushed the feature/upgrade-eth-keyring-controller branch from cb68819 to 11f69d1 Compare May 11, 2021 18:56
@rickycodes rickycodes marked this pull request as ready for review May 12, 2021 15:47
@rickycodes rickycodes requested a review from a team as a code owner May 12, 2021 15:47
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickycodes rickycodes merged commit e2adf31 into develop May 13, 2021
@rickycodes rickycodes deleted the feature/upgrade-eth-keyring-controller branch May 13, 2021 02:54
@Gudahtt Gudahtt mentioned this pull request May 18, 2021
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants