fix: update profile-sync notification settings path hash #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
dovydas55
previously approved these changes
Sep 17, 2024
Prithpal-Sooriya
force-pushed
the
NOTIFY-1115/fix-profile-sync-path-hashing
branch
from
f836424
to
d09e15a
Compare
Prithpal-Sooriya
deleted the
NOTIFY-1115/fix-profile-sync-path-hashing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This is a critical fix that ensures that we use the correct path hash used in extension for creating UserStorage for notification settings.
References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1115
Changelog
@metamask/profile-sync-controllernotification_settingspath hash.@metamask/notification-services-controllernotificationSettingstonotification_settingsto use correct storage schema.Checklist