Fix resetPolling functionality
#546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjm
approved these changes
Jul 28, 2021
rickycodes
changed the title
rickycodes
changed the title
resetPolling functionality
Merged
rickycodes
added a commit
that referenced
this pull request
Aug 3, 2021
…to dynamic-speed-up * 'dynamic-speed-up' of github.com:MetaMask/controllers: Bump @metamask/auto-changelog from 2.4.0 to 2.5.0 (#549) Update Changelog (#548) 14.0.2 (#547) Fix `resetPolling` functionality (#546) TokenService improvements (#541) Release/14.0.1 (#545) Make gweiDecToWEIBN util resilient against params with too many decimals (#544) Bump @metamask/contract-metadata from 1.27.0 to 1.28.0 (#540) 14.0.0 (#539) Bug: Mainnet NFT Autodetect API (#536)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* use this.getGasFeeEstimatesAndStartPolling * Only call resetPolling if ChainId has actually changed * Again, only update if isEIP1559Compatible has changed * Also update this.currentChainId * use getChainId() * Use this.getChainId() Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
* use this.getGasFeeEstimatesAndStartPolling * Only call resetPolling if ChainId has actually changed * Again, only update if isEIP1559Compatible has changed * Also update this.currentChainId * use getChainId() * Use this.getChainId() Co-authored-by: Andre Pimenta <andrepimenta7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the problem of the resetPolling being called on every network controller state change, so more frequent than necessary. We now check by chainId if the network changed and we don't update the network controller properties if they are the same.