Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix collectibles collection images #650

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix collectibles collection images #650

merged 2 commits into from
Dec 1, 2021

Conversation

wachunei
Copy link
Member

@wachunei wachunei commented Dec 1, 2021

Description

  • FIXED:

    • Avoid overwriting collection property from getCollectibleInformation, this was causing collection.image_url to be null.

Checklist

  • Tests are included if applicable
  • Any added code is fully documented

@wachunei wachunei marked this pull request as ready for review December 1, 2021 16:24
@wachunei wachunei requested a review from a team as a code owner December 1, 2021 16:24
adonesky1
adonesky1 approved these changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei merged commit 2002de5 into main Dec 1, 2021
@wachunei wachunei deleted the fix/collectibles-collection-images branch December 1, 2021 16:44
@adonesky1 adonesky1 mentioned this pull request Dec 1, 2021
Merged
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@wachunei @adonesky1 @MajorLift
Fix collectibles collection images (#650)
6e850a1 
Co-authored-by: Alex Donesky <adonesky@gmail.com>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@wachunei @adonesky1 @MajorLift
Fix collectibles collection images (#650)
bfa8fa6 
Co-authored-by: Alex Donesky <adonesky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adonesky1 adonesky1 adonesky1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wachunei @adonesky1