Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move new keystone package to dependencies #757

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Move new keystone package to dependencies #757

merged 1 commit into from
Mar 30, 2022

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Mar 30, 2022

KeyringController now imports @keystonehq/metamask-airgapped-keyring.
This should not be included in devDependencies, but rather
dependencies. This is causing issues downstream.

@mcmire
Move new keystone package to dependencies
38a77b0 
KeyringController now imports `@keystonehq/metamask-airgapped-keyring`.
This should not be included in `devDependencies`, but rather
`dependencies`. This is causing issues downstream.
@mcmire mcmire requested a review from a team as a code owner March 30, 2022 15:48
@mcmire mcmire mentioned this pull request Mar 30, 2022
Merged
Gudahtt
Gudahtt approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire mcmire merged commit 429a39e into main Mar 30, 2022
@mcmire mcmire deleted the move-keystone-dep branch March 30, 2022 15:51
@wachunei
Copy link
Member

¿can we import type since we are just importing types? this will bundle the whole thing

@wachunei
Copy link
Member

omg guys you are so fast you merged while I was asking hahaha

@gantunesr
Copy link
Member

Really fast, I was just about to open the PR. Thanks @mcmire @Gudahtt

rickycodes added a commit that referenced this pull request Apr 7, 2022
@rickycodes
Merge branch 'add-npm-publish' of github.com:MetaMask/controllers int…
19a1e24 
…o add-npm-publish

* 'add-npm-publish' of github.com:MetaMask/controllers:
  Improve support for backfilling types via .d.ts's (#732)
  Copy .gitattributes from template repo (#760)
  27.1.1 (#759)
  Move new keystone package to dependencies (#757)
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mcmire @MajorLift
Move new keystone package to dependencies (#757)
0b12852 
KeyringController now imports `@keystonehq/metamask-airgapped-keyring`.
This should not be included in `devDependencies`, but rather
`dependencies`. This is causing issues downstream.
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mcmire @MajorLift
Move new keystone package to dependencies (#757)
67e2df9 
KeyringController now imports `@keystonehq/metamask-airgapped-keyring`.
This should not be included in `devDependencies`, but rather
`dependencies`. This is causing issues downstream.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcmire @wachunei @gantunesr @Gudahtt