Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dry run publish just before actual publish #842

Merged
merged 1 commit into from
May 27, 2022
Merged

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented May 26, 2022

This adds a dry run publish just prior to the actual npm publish so the person approving the publish can check the dry-run output of the preceding job to verify the publish does what's expected.

I've tested this action using a similar flow in a personal project here: https://github.com/rickycodes/card/actions/runs/2391846238

@rickycodes rickycodes requested a review from a team as a code owner May 26, 2022 16:34
@rickycodes rickycodes force-pushed the feature/add-dry-run branch 2 times, most recently from 17dca05 to 074834b Compare May 26, 2022 16:38
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rickycodes rickycodes merged commit 5f6bdba into main May 27, 2022
@rickycodes rickycodes deleted the feature/add-dry-run branch May 27, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants