Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Etherscan API as Alethio API is getting deprecated #2111

Closed
omnat opened this issue Jan 12, 2021 · 4 comments · Fixed by #2253
Closed

Migrate to Etherscan API as Alethio API is getting deprecated #2111

omnat opened this issue Jan 12, 2021 · 4 comments · Fixed by #2253
Assignees

Comments

@omnat
Copy link
Contributor

omnat commented Jan 12, 2021

Codefi team needs deprecate the Alethio API. This impacts MetaMask mobile users, so we should notify them of this disruption to avoid any confusion/panic.

User impact

With this deprecation, the received token transfers will stop working on mobile - so let's migrate to another service.
If we don't migrate, the incoming token transfers will be temporarily unavailable - users wouldn’t know of this and it cause them confusion unless we inform them sufficiently.

Task:

Utilize Etherscan API to show received tokens in the history. This will apply for tokens that have been added to the wallet, and for newly added tokens that match the token registry.

Note: We tested it locally that Alethio API deprecation would not cause unexpected issues on the mobile app. cc @estebanmino

@omnat omnat added the needs-design Feature that requires UI/UX design label Jan 12, 2021
@omnat
Copy link
Contributor Author

omnat commented Jan 12, 2021

Omna waiting to hear from Codefi team to put a date on the deprecation.

@omnat omnat changed the title Notify users that we are deprecating Alethio API Migrate to Etherscan API as Alethio API is getting deprecated Jan 19, 2021
@omnat
Copy link
Contributor Author

omnat commented Jan 19, 2021

@omnat to ask for an Etherscan API key for this from Etherscan team

@omnat omnat self-assigned this Jan 19, 2021
@omnat omnat removed their assignment Jan 22, 2021
@omnat
Copy link
Contributor Author

omnat commented Jan 22, 2021

We have the API key, this is ready to be picked up. Shared with Esteban, but if someone else picks it up, please ping me for the key

@omnat omnat removed the needs-design Feature that requires UI/UX design label Jan 25, 2021
@rickycodes rickycodes removed their assignment Jan 28, 2021
@rickycodes rickycodes mentioned this issue Feb 17, 2021
3 tasks
@omnat
Copy link
Contributor Author

omnat commented Feb 22, 2021

Notes on Etherscan plan: https://roamresearch.com/#/app/MetaMask/page/x3jYpsW9a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants