Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Etherscan API #2253

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Use Etherscan API #2253

merged 1 commit into from
Mar 10, 2021
+2 −1

Conversation

rickycodes
Copy link
Member

Description

This removes alethioApiKey and instead uses etherscanApiKey

Opening as a draft until MetaMask/core#351 is completed/merged

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2111

@rickycodes rickycodes added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 19, 2021
@ibrahimtaveras00 ibrahimtaveras00 added QA'd but questions A QA run through has been done but you need clarification on minor issues you found and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 8, 2021
@rickycodes rickycodes force-pushed the feature/migrate-to-etherscan branch 2 times, most recently from df4521d to a8962b5 Compare March 9, 2021 22:11
ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA'd but questions A QA run through has been done but you need clarification on minor issues you found labels Mar 9, 2021
@rickycodes rickycodes marked this pull request as ready for review March 10, 2021 00:15
@rickycodes rickycodes requested a review from a team as a code owner March 10, 2021 00:15
estebanmino
estebanmino approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@rickycodes rickycodes force-pushed the feature/migrate-to-etherscan branch 2 times, most recently from 5387d0b to ddd2073 Compare March 10, 2021 15:56
@rickycodes rickycodes merged commit 9114b2c into develop Mar 10, 2021
@rickycodes rickycodes deleted the feature/migrate-to-etherscan branch March 10, 2021 16:04
@rickycodes rickycodes restored the feature/migrate-to-etherscan branch March 10, 2021 16:25
@rickycodes rickycodes deleted the feature/migrate-to-etherscan branch March 10, 2021 16:26
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Use Etherscan API (#2253)
9db86d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to Etherscan API as Alethio API is getting deprecated
4 participants
@rickycodes @estebanmino @ibrahimtaveras00 @omnat