Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/show previously created accounts on seed phrase import #1879

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Feature/show previously created accounts on seed phrase import #1879

merged 5 commits into from
Oct 22, 2020

Conversation

rickycodes
Copy link
Member

@rickycodes rickycodes commented Oct 7, 2020 •
edited
Loading

Previously when importing from seed phrase we only imported the initial account:

image

Now we match extension functionality and import until we hit an account with a zero balance, which for me looks like this:

image

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1824

@rickycodes rickycodes marked this pull request as ready for review October 7, 2020 18:53
@rickycodes rickycodes requested a review from a team as a code owner October 7, 2020 18:53
@rickycodes rickycodes added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Oct 7, 2020
@rickycodes rickycodes force-pushed the feature/show-previously-created-accounts branch from 70afbac to 87815f2 Compare October 8, 2020 18:52
@estebanmino estebanmino self-requested a review October 8, 2020 19:54
estebanmino
estebanmino approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rickycodes rickycodes force-pushed the feature/show-previously-created-accounts branch from 8ff46e4 to 8fdefe9 Compare October 9, 2020 03:31
@rickycodes rickycodes changed the title Feature/show previously created accounts Feature/show previously created accounts on seed phrase import Oct 9, 2020
@rickycodes rickycodes marked this pull request as draft October 13, 2020 20:45
@rickycodes rickycodes mentioned this pull request Oct 13, 2020
Merged
@rickycodes rickycodes force-pushed the feature/show-previously-created-accounts branch from 4e5b8cd to e8e71ba Compare October 15, 2020 16:37
@rickycodes rickycodes removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 15, 2020
ibrahimtaveras00
ibrahimtaveras00 approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Oct 21, 2020
@rickycodes rickycodes force-pushed the feature/show-previously-created-accounts branch from e8e71ba to c0706fb Compare October 22, 2020 19:07
@rickycodes rickycodes marked this pull request as ready for review October 22, 2020 19:09
@rickycodes rickycodes merged commit a7d6c01 into develop Oct 22, 2020
@rickycodes rickycodes deleted the feature/show-previously-created-accounts branch October 22, 2020 19:25
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Feature/show previously created accounts on seed phrase import (#1879)
ee01e99 
* Import additional accounts on seedphrase import

* Import additional accounts in the background

* Add updateIdentities method

* Add comments for newly added code

* Use 3.2.0 version of controllers
@Gudahtt Gudahtt mentioned this pull request Jan 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
next release QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show all accounts when restoring wallet using seed phrase
3 participants
@rickycodes @estebanmino @ibrahimtaveras00