Add Yarn 3 allow-scripts plugin (#545)

* Add Yarn 3 allow-scripts plugin

* Remove usage of yarn setup

* Remove manual instances of calling allow-scripts

* Re-add setup command for backwards compatability

.github/workflows/build-lint-test.yml

@@ -27,7 +27,6 @@ jobs:
           path: .yarn/cache
           key: yarn-cache-${{ runner.os }}-${{ steps.yarn-version.outputs.YARN_VERSION }}-${{ hashFiles('yarn.lock') }}
       - run: yarn install --immutable
-      - run: yarn allow-scripts
       - run: yarn build
       - name: Require clean working directory
         shell: bash
@@ -76,7 +75,6 @@ jobs:
       # To use the --immutable flag, we have to install all dependencies, not
       # just the ones we need.
       - run: yarn install --immutable
-      - run: yarn allow-scripts
       - name: Build @metamask/snaps-cli and its dependents only
         shell: bash
         run: |

.yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs

@@ -0,0 +1,9 @@
+/* eslint-disable */
+//prettier-ignore
+module.exports = {
+name: "@yarnpkg/plugin-allow-scripts",
+factory: function (require) {
+var plugin=(()=>{var a=Object.create,l=Object.defineProperty;var i=Object.getOwnPropertyDescriptor;var s=Object.getOwnPropertyNames;var p=Object.getPrototypeOf,c=Object.prototype.hasOwnProperty;var u=e=>l(e,"__esModule",{value:!0});var f=e=>{if(typeof require!="undefined")return require(e);throw new Error('Dynamic require of "'+e+'" is not supported')};var g=(e,o)=>{for(var r in o)l(e,r,{get:o[r],enumerable:!0})},m=(e,o,r)=>{if(o&&typeof o=="object"||typeof o=="function")for(let t of s(o))!c.call(e,t)&&t!=="default"&&l(e,t,{get:()=>o[t],enumerable:!(r=i(o,t))||r.enumerable});return e},x=e=>m(u(l(e!=null?a(p(e)):{},"default",e&&e.__esModule&&"default"in e?{get:()=>e.default,enumerable:!0}:{value:e,enumerable:!0})),e);var k={};g(k,{default:()=>d});var n=x(f("@yarnpkg/shell")),y={hooks:{afterAllInstalled:async()=>{let e=await(0,n.execute)("yarn run allow-scripts");e!==0&&process.exit(e)}}},d=y;return k;})();
+return plugin;
+}
+};

.yarnrc.yml

@@ -1,9 +1,11 @@
-nodeLinker: node-modules
-
 enableScripts: false
 
+nodeLinker: node-modules
+
 plugins:
   - path: .yarn/plugins/@yarnpkg/plugin-workspace-tools.cjs
     spec: '@yarnpkg/plugin-workspace-tools'
+  - path: .yarn/plugins/@yarnpkg/plugin-allow-scripts.cjs
+    spec: 'https://raw.githubusercontent.com/LavaMoat/LavaMoat/main/packages/yarn-plugin-allow-scripts/bundles/@yarnpkg/plugin-allow-scripts.js'
 
 yarnPath: .yarn/releases/yarn-3.2.1.cjs

README.md

@@ -6,7 +6,7 @@ Monorepo for experimental snaps dependencies.
 
 ### Installing
 
-Run `yarn setup` in the project root directory.
+Run `yarn install` in the project root directory.
 Do **not** run any installation commands in individual workspaces.
 
 If you add a dependency with a lifecycle script, said dependency must be added to the `devDependencies` and `lavamoat.allow-scripts` config of the root `package.json` file.

package.json

@@ -10,8 +10,8 @@
     "packages/*"
   ],
   "scripts": {
-    "setup": "yarn install && yarn allow-scripts && yarn postinstall && yarn simple-git-hooks",
-    "postinstall": "patch-package",
+    "setup": "yarn install",
+    "postinstall": "patch-package && simple-git-hooks",
     "publish:all": "./scripts/publish-all.sh",
     "link-packages": "./scripts/link-packages.sh",
     "lint:eslint": "eslint . --cache --ext js,ts",

packages/cli/package.json

@@ -14,7 +14,6 @@
     "dist/"
   ],
   "scripts": {
-    "setup": "yarn install && yarn allow-scripts",
     "shasum": "node ./scripts/computeSnapShasum.js",
     "build:init-template": "node ./scripts/createInitTemplate.js && yarn prettier --check src/cmds/init/init-template.json",
     "build:guards": "ts-auto-guard --guard-file-name=__GENERATED__ ./src/utils/snap-config.ts",

packages/examples/package.json

@@ -15,7 +15,6 @@
     "examples/*"
   ],
   "scripts": {
-    "setup": "yarn install && yarn allow-scripts",
     "lint:changelog": "yarn auto-changelog validate",
     "lint:eslint": "eslint . --cache --ext js,ts",
     "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' --ignore-path ../../.gitignore",

packages/execution-environments/package.json

@@ -16,7 +16,6 @@
     "posttest": "jest-it-up",
     "test:ci": "yarn test",
     "test:watch": "jest --watch",
-    "setup": "yarn install && yarn allow-scripts",
     "lint:eslint": "eslint . --cache --ext js,ts",
     "lint:misc": "prettier '**/*.json' '**/*.md' '!CHANGELOG.md' --ignore-path .gitignore",
     "lint:fix": "yarn lint:eslint --fix && yarn lint:misc --write",

scripts/publish-all.sh

@@ -9,7 +9,7 @@ set -o pipefail
 # git working tree remains cleans, then asks for an npm 2FA code and publishes
 # all packages.
 
-yarn setup
+yarn install
 yarn build:clean
 yarn lint