Remove JSDOM from all packages #1241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1241 +/- ##
==========================================
- Coverage 94.82% 94.82% -0.01%
==========================================
Files 142 142
Lines 4364 4363 -1
Branches 717 717
==========================================
- Hits 4138 4137 -1
Misses 226 226
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
force-pushed
the
mrtenz/wdio
branch
3 times, most recently
from
232ec1d
to
4434bac
Compare
Mrtenz
force-pushed
the
mrtenz/remove-jsdom
branch
from
6056530
to
07847c4
Compare
Mrtenz
force-pushed
the
mrtenz/remove-jsdom
branch
from
eab0894
to
e2e812e
Compare
FrederikBolding
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1231, there are a couple of packages still using JSDOM. In this PR I've updated those packages to use the Node.js environment where possible, and implemented
webdriverioif not.