feat: Add RadioButton component #2592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2592 +/- ##
==========================================
+ Coverage 94.00% 94.01% +0.01%
==========================================
Files 459 461 +2
Lines 9650 9678 +28
Branches 1482 1486 +4
==========================================
+ Hits 9071 9099 +28
Misses 579 579 ☔ View full report in Codecov by Sentry. |
david0xd
force-pushed
the
dd/radio-button-component
branch
from
e2bde28
to
b9ace1d
Compare
david0xd
force-pushed
the
dd/radio-button-component
branch
from
65088a2
to
ef73c1b
Compare
GuillaumeRx
reviewed
Jul 24, 2024
GuillaumeRx
approved these changes
Jul 24, 2024
7 tasks
david0xd
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 1, 2024
### Waiting on release of: MetaMask/snaps#2592 ## **Description** This PR integrates new Radio components for Snap UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#1571 ## **Manual testing steps** 1. Go to `Test Snaps` and install `Interactive UI Snap`. 2. Run Interactive UI Snap by creating a dialog. 3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use `main` branch in Snaps repo and run locally if necessary) ## **Screenshots/Recordings** ### **Before** Nothing to show. Radio options were not available before. ### **After**    ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 12, 2024
](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1){kind=link}
### Waiting on release of: MetaMask/snaps#2592 ## **Description** This PR integrates new Radio components for Snap UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#1571 ## **Manual testing steps** 1. Go to `Test Snaps` and install `Interactive UI Snap`. 2. Run Interactive UI Snap by creating a dialog. 3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use `main` branch in Snaps repo and run locally if necessary) ## **Screenshots/Recordings** ### **Before** Nothing to show. Radio options were not available before. ### **After**    ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 13, 2024
### Waiting on release of: MetaMask/snaps#2592 ## **Description** This PR integrates new Radio components for Snap UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#1571 ## **Manual testing steps** 1. Go to `Test Snaps` and install `Interactive UI Snap`. 2. Run Interactive UI Snap by creating a dialog. 3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use `main` branch in Snaps repo and run locally if necessary) ## **Screenshots/Recordings** ### **Before** Nothing to show. Radio options were not available before. ### **After**    ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 14, 2024
### Waiting on release of: MetaMask/snaps#2592 ## **Description** This PR integrates new Radio components for Snap UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#1571 ## **Manual testing steps** 1. Go to `Test Snaps` and install `Interactive UI Snap`. 2. Run Interactive UI Snap by creating a dialog. 3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use `main` branch in Snaps repo and run locally if necessary) ## **Screenshots/Recordings** ### **Before** Nothing to show. Radio options were not available before. ### **After**    ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
FrederikBolding
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
Aug 14, 2024
### Waiting on release of: MetaMask/snaps#2592 ## **Description** This PR integrates new Radio components for Snap UI. [](https://codespaces.new/MetaMask/metamask-extension/pull/26181?quickstart=1) ## **Related issues** Fixes: MetaMask/MetaMask-planning#1571 ## **Manual testing steps** 1. Go to `Test Snaps` and install `Interactive UI Snap`. 2. Run Interactive UI Snap by creating a dialog. 3. Check that radio options are available in the UI and confirm their functionality. (Latest Test Snaps needs to be released before this is possible, use `main` branch in Snaps repo and run locally if necessary) ## **Screenshots/Recordings** ### **Before** Nothing to show. Radio options were not available before. ### **After**    ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for a
RadioGroup/Radiocomponent, that can be used on its own or as part of aField.Similarly to
Input, it optionally uses value to determine the initial value/preselectedRadioitem. This can also be used to control the input when re-rendering with snap_updateInterface. TheRadioGroupwill also triggerInputChangeEventsimilarly to anInput.This PR mostly adds validation and types for this new component as well as some handling for the form state. This will need a follow-up PR in the extension to complete integration. This PR also adds support for
chooseFromRadioGrouptosnaps-jestand uses this new component in theInteractive UI example Snap.Related task: https://github.com/MetaMask/MetaMask-planning/issues/1571