fix: Disallow images and icons in footers #2676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
force-pushed
the
fb/disallow-images-in-footers
branch
from
760f179
to
6612283
Compare
|
@metamaskbot update-pr |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2676 +/- ##
==========================================
+ Coverage 94.28% 94.29% +0.01%
==========================================
Files 480 481 +1
Lines 10013 10031 +18
Branches 1502 1511 +9
==========================================
+ Hits 9441 9459 +18
Misses 572 572 ☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Aug 29, 2024
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
|
@metamaskbot update-pr |
Mrtenz
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disallow images and icons in buttons that are present in the footer of a confirmation.