Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow CAIP-10 addresses in Address #2680

Merged
merged 5 commits into from
Sep 2, 2024
Merged

feat: Allow CAIP-10 addresses in Address #2680

merged 5 commits into from
Sep 2, 2024

Conversation

FrederikBolding
Copy link
Member

Allow CAIP-10 addresses in the Address component.

This will need a follow-up PR in the extension to support as well.

@FrederikBolding FrederikBolding changed the title feat: Allow CAIP-10 addresses feat: Allow CAIP-10 addresses in Address Aug 30, 2024
@socket-security Socket Security
Copy link

socket-security bot commented Aug 30, 2024 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@metamask/utils@9.1.0)

View full report↗︎

@FrederikBolding
Copy link
Member Author

@metamaskbot update-pr

@codecov Codecov
Copy link

codecov bot commented Aug 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (dcb4f0a) to head (5ad08fc).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2680   +/-   ##
=======================================
  Coverage   94.30%   94.30%           
=======================================
  Files         481      481           
  Lines       10040    10040           
  Branches     1512     1512           
=======================================
  Hits         9468     9468           
  Misses        572      572

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@FrederikBolding FrederikBolding marked this pull request as ready for review September 2, 2024 08:33
@FrederikBolding FrederikBolding requested a review from a team as a code owner September 2, 2024 08:33
@FrederikBolding FrederikBolding merged commit 45e7323 into main Sep 2, 2024
156 checks passed
@FrederikBolding FrederikBolding deleted the fb/allow-caip10-addresses branch September 2, 2024 08:45
Mrtenz pushed a commit that referenced this pull request Sep 2, 2024
@FrederikBolding @metamaskbot @Mrtenz
feat: Allow CAIP-10 addresses in Address (#2680)
e8dcd17 
Allow CAIP-10 addresses in the `Address` component.

This will need a follow-up PR in the extension to support as well.

---------

Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mrtenz Mrtenz Mrtenz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrederikBolding @Mrtenz @metamaskbot