Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added form property to Button JSX component #2712

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Added form property to Button JSX component #2712

merged 4 commits into from
Sep 12, 2024

Conversation

ritave
Copy link
Member

@ritave ritave commented Sep 11, 2024

This will allow Button in the Footer be linked to a specific form so that it also can submit the form.

<Container>
  <Form name="foo">
    <Input />
  </Form>
  <Footer>
    <Button type="submit" form="foo" />
  </Footer>
</Container>

@ritave ritave requested a review from a team as a code owner September 11, 2024 14:28
ritave and others added 2 commits September 11, 2024 16:43
Co-authored-by: Maarten Zuidhoorn <maarten@zuidhoorn.com>
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (0ff5b13) to head (3e20ec7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2712   +/-   ##
=======================================
  Coverage   94.35%   94.35%           
=======================================
  Files         481      481           
  Lines       10129    10129           
  Branches     1540     1540           
=======================================
  Hits         9557     9557           
  Misses        572      572           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz merged commit dfaea71 into main Sep 12, 2024
156 checks passed
@Mrtenz Mrtenz deleted the ritave/button-form branch September 12, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants