Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-8618) Add note to Measure-Object in 7.3 #8638

Conversation

michaeltlombardi
Copy link
Contributor

PR Summary

This commit adds a note to the Measure-Object cmdlet reference documentation for PowerShell 7.3 to clarify that it now only returns an argument error when an object is missing the to-measure property in StrictMode to pair with the updated implementation from PowerShell/PowerShell#16589.

PR Context

Check the boxes below to indicate the content affected by this PR.

Repository or docset configuration

  • Repo documentation and configuration (.git/.github/.vscode etc.)
  • Docs build files (.openpublishing.* and build scripts)
  • Docset configuration (docfx.json, mapping, bread, module folder)

Conceptual documentation

  • Files in docs-conceptual

Cmdlet reference & about_ topics
When changing cmdlet reference or about_ topics, the changes should be copied to all
relevant versions. Check the boxes below to indicate the versions affected by this change.

  • Preview content
  • Version 7.2 content
  • Version 7.1 content
  • Version 7.0 content
  • Version 5.1 content

PR Checklist

  • I have read the contributors guide and followed the style and process guidelines
  • PR has a meaningful title
  • PR is targeted at the staging branch
  • All relevant versions updated
  • Includes content related to issues and PRs - see Closing issues using keywords.
  • This PR is ready to merge and is not Work in Progress. If the PR is work in progress,
    please add the prefix WIP: or [WIP] to the beginning of the title and remove the prefix when
    the PR is ready.

This commit adds a note to the `Measure-Object` cmdlet reference
documentation for PowerShell 7.3 to clarify that it now only returns
an argument error when an object is missing the to-measure property
in **StrictMode** to pair with the updated implementation from
PowerShell/PowerShell#16589.
@opbld33
Copy link

opbld33 commented Mar 8, 2022

Docs Build status updates of commit 186ddb5:

✅ Validation status: passed

File Status Preview URL Details
reference/7.3/Microsoft.PowerShell.Utility/Measure-Object.md ✅Succeeded View (powershell-7.3)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Contributor

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edit. Watch your "which" vs. "that". See https://www.quickanddirtytips.com/education/grammar/which-versus-that

Co-authored-by: Sean Wheeler <sean.wheeler@microsoft.com>
@opbld33
Copy link

opbld33 commented Mar 9, 2022

Docs Build status updates of commit 3188f82:

✅ Validation status: passed

File Status Preview URL Details
reference/7.3/Microsoft.PowerShell.Utility/Measure-Object.md ✅Succeeded View (powershell-7.3)

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@sdwheeler sdwheeler merged commit d946fe4 into MicrosoftDocs:staging Mar 9, 2022
@michaeltlombardi michaeltlombardi deleted the GH-8618/staging/measure-object branch March 10, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Measure-Object ignore missing properties unless running in strict mode
3 participants