Update openos/lib/uuid.lua to generate valid RFC4122 version 4 UUIDs #2715
Conversation
| byte = bit32.bor(bit32.band(byte, 0x3F), 0x80) | ||
| end | ||
| result = result .. string.format("%02x", byte) | ||
| pos = pos + 1 |
There was a problem hiding this comment.
Can one just use i instead of maintaining a separate counter?
There was a problem hiding this comment.
The value of i is from 1 to the value of 4, 2 or 6 depending on the part of the uuid being generated. Thus you would still need to maintain an index of which section of the uuid you're generating.
For example the 2 options are the method I used, or a method where the option for byte 6 is byte 1 or part 3 and byte 8 is byte 1 of part 4. So you could change "for _,set in ipairs(sets) do" to "for part,set in ipairs(sets) do" and then use "if part == 3 and i == 1 then" and "if part == 4 and i == 1" instead of "if pos == 6 then" and "if pos == 8 then" respectively. The result would then be the same.
There was a problem hiding this comment.
Ahhh, woops. I evidently failed to read the code properly - sorry.
Pull request relating to issue #2713